Normalize mcp plugin secret/connection refs#520
Closed
RhysSullivan wants to merge 1 commit intors/normalize-openapifrom
Closed
Normalize mcp plugin secret/connection refs#520RhysSullivan wants to merge 1 commit intors/normalize-openapifrom
RhysSullivan wants to merge 1 commit intors/normalize-openapifrom
Conversation
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced May 4, 2026
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 5d47fb8 | May 05 2026, 06:29 PM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 5d47fb8 | Commit Preview URL Branch Preview URL |
May 05 2026, 06:29 PM |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/storage-core
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-google-discovery
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
force-pushed
the
rs/normalize-mcp
branch
from
eca66cf to
45caef2
Compare
RhysSullivan
force-pushed
the
rs/normalize-openapi
branch
2 times, most recently
from
5a7fa76 to
8d1c6eb
Compare
RhysSullivan
force-pushed
the
rs/normalize-mcp
branch
from
45caef2 to
5da3d2b
Compare
Move secret/connection references out of the JSON `mcp_source.config` column into: - Flat columns on mcp_source: auth_kind, auth_header_name, auth_secret_id, auth_secret_prefix, auth_connection_id, auth_client_id_secret_id, auth_client_secret_secret_id (each indexed where it carries a ref). Replaces the McpConnectionAuth json blob. - mcp_source_header / mcp_source_query_param: child tables for the remote source's SecretBackedMap entries (same shape as graphql / openapi child tables). The remaining structural fields (transport, endpoint, command, args, etc.) stay as JSON in `config` because they're plugin-private and vary by transport. mcp_binding.binding stays JSON too — McpToolBinding carries no refs and inputSchema/outputSchema are arbitrary user JSON. Plugin gains usagesForSecret / usagesForConnection. Migration 0009 backfills via json_extract / json_each, then strips the extracted fields with json_remove. Three migration tests cover backfill from a hand-seeded pre-migration DB; two plugin-level tests cover usage fan-out across header-auth and oauth2 sources.
RhysSullivan
force-pushed
the
rs/normalize-mcp
branch
from
5da3d2b to
5d47fb8
Compare
RhysSullivan
force-pushed
the
rs/normalize-openapi
branch
from
8d1c6eb to
22e0bb7
Compare
Owner
Author
|
Consolidated into #521 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move secret/connection references out of the JSON
mcp_source.configcolumn into:
auth_secret_id, auth_secret_prefix, auth_connection_id,
auth_client_id_secret_id, auth_client_secret_secret_id (each indexed
where it carries a ref). Replaces the McpConnectionAuth json blob.
remote source's SecretBackedMap entries (same shape as graphql /
openapi child tables).
The remaining structural fields (transport, endpoint, command, args,
etc.) stay as JSON in
configbecause they're plugin-private and varyby transport. mcp_binding.binding stays JSON too — McpToolBinding
carries no refs and inputSchema/outputSchema are arbitrary user JSON.
Plugin gains usagesForSecret / usagesForConnection. Migration 0009
backfills via json_extract / json_each, then strips the extracted
fields with json_remove. Three migration tests cover backfill from a
hand-seeded pre-migration DB; two plugin-level tests cover usage
fan-out across header-auth and oauth2 sources.